Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: adr for enabling producing to event bus via settings #224

Merged
merged 1 commit into from
Jun 26, 2023
Merged

docs: adr for enabling producing to event bus via settings #224

merged 1 commit into from
Jun 26, 2023

Conversation

navinkarkera
Copy link
Contributor

@navinkarkera navinkarkera commented May 23, 2023 •
edited
Loading

Description: ADR for enabling producing to event bus via settings

ISSUE: #210

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed

Post merge:

  • Create a tag
  • Check new version is pushed to PyPI after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)

@navinkarkera navinkarkera requested a review from a team as a code owner May 23, 2023 06:29
@openedx-webhooks
Copy link

Thanks for the pull request, @navinkarkera! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 23, 2023
@timmc-edx timmc-edx self-assigned this May 23, 2023
timmc-edx
timmc-edx reviewed May 24, 2023
View reviewed changes
docs/decisions/0011-producing-to-event-bus-via-settings.rst Outdated Show resolved Hide resolved
docs/decisions/0011-producing-to-event-bus-via-settings.rst Outdated Show resolved Hide resolved
docs/decisions/0011-producing-to-event-bus-via-settings.rst Outdated Show resolved Hide resolved
docs/decisions/0011-producing-to-event-bus-via-settings.rst Outdated Show resolved Hide resolved
docs/decisions/0011-producing-to-event-bus-via-settings.rst Outdated Show resolved Hide resolved
docs/decisions/0011-producing-to-event-bus-via-settings.rst Outdated Show resolved Hide resolved
docs/decisions/0011-producing-to-event-bus-via-settings.rst Outdated Show resolved Hide resolved
docs/decisions/0011-producing-to-event-bus-via-settings.rst Outdated Show resolved Hide resolved
@navinkarkera navinkarkera force-pushed the navin/configurable-handler-adr branch from 42568a5 to ca804fc Compare May 26, 2023 06:10
@navinkarkera navinkarkera force-pushed the navin/configurable-handler-adr branch from ca804fc to 4db9565 Compare May 31, 2023 09:55
tecoholic
tecoholic approved these changes May 31, 2023
View reviewed changes
Copy link

@tecoholic tecoholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@navinkarkera 👍 LGTM

  • I tested this: NA
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

@mphilbrick211
Copy link

@mariajgrimaldi would you be able to review/merge this?

robrap
robrap reviewed Jun 1, 2023
View reviewed changes
Copy link
Contributor

@robrap robrap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm excited about this change. Thanks for the ADR work.

docs/decisions/0011-producing-to-event-bus-via-settings.rst Outdated Show resolved Hide resolved
docs/decisions/0011-producing-to-event-bus-via-settings.rst Outdated Show resolved Hide resolved
docs/decisions/0011-producing-to-event-bus-via-settings.rst Outdated Show resolved Hide resolved
docs/decisions/0011-producing-to-event-bus-via-settings.rst Outdated Show resolved Hide resolved
docs/decisions/0011-producing-to-event-bus-via-settings.rst Outdated Show resolved Hide resolved
docs/decisions/0011-producing-to-event-bus-via-settings.rst Outdated Show resolved Hide resolved
docs/decisions/0011-producing-to-event-bus-via-settings.rst Outdated Show resolved Hide resolved
docs/decisions/0011-producing-to-event-bus-via-settings.rst Outdated Show resolved Hide resolved
docs/decisions/0011-producing-to-event-bus-via-settings.rst Outdated Show resolved Hide resolved
@robrap robrap self-requested a review June 1, 2023 20:55
@navinkarkera navinkarkera force-pushed the navin/configurable-handler-adr branch from 4db9565 to 2f4dbed Compare June 5, 2023 06:48
@navinkarkera navinkarkera requested a review from timmc-edx June 5, 2023 06:53
robrap
robrap reviewed Jun 5, 2023
View reviewed changes
Copy link
Contributor

@robrap robrap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have someone else join in on the discussion of where to define defaults. Thank you.

docs/decisions/0011-producing-to-event-bus-via-settings.rst Outdated Show resolved Hide resolved
docs/decisions/0011-producing-to-event-bus-via-settings.rst Outdated Show resolved Hide resolved
docs/decisions/0011-producing-to-event-bus-via-settings.rst Outdated Show resolved Hide resolved
docs/decisions/0011-producing-to-event-bus-via-settings.rst Outdated Show resolved Hide resolved
docs/decisions/0011-producing-to-event-bus-via-settings.rst Outdated Show resolved Hide resolved
docs/decisions/0011-producing-to-event-bus-via-settings.rst Outdated Show resolved Hide resolved
@navinkarkera navinkarkera force-pushed the navin/configurable-handler-adr branch from b1d9611 to fd624f9 Compare June 6, 2023 05:33
@bmtcril bmtcril mentioned this pull request Jun 6, 2023
Merged
9 tasks
@navinkarkera navinkarkera requested review from timmc-edx and robrap June 7, 2023 06:51
@sameenfatima78
Copy link
Member

@mariajgrimaldi @mphilbrick211 @robrap Hi folks, would it be possible to get this merged soon? It will really help with the deployment of our project.

@robrap
Copy link
Contributor

robrap commented Jun 9, 2023

@sameenfatima78: Navin will need to speak to the timeline. At the same time, temporarily adding the hardcoded version with a feature flag shouldn’t be a big deal and will keep you unblocked. Let me know if you want to discuss further.

timmc-edx
timmc-edx reviewed Jun 9, 2023
View reviewed changes
docs/decisions/index.rst Outdated Show resolved Hide resolved
mariajgrimaldi
mariajgrimaldi approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@mariajgrimaldi mariajgrimaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few tiny comments

@navinkarkera navinkarkera force-pushed the navin/configurable-handler-adr branch from 6bec8e9 to 0ef040a Compare June 14, 2023 04:41
This was referenced Jun 14, 2023
Merged
Merged
@navinkarkera navinkarkera force-pushed the navin/configurable-handler-adr branch from 0ef040a to d96b3d1 Compare June 23, 2023 09:41
@navinkarkera navinkarkera force-pushed the navin/configurable-handler-adr branch from d96b3d1 to 17c7dd3 Compare June 26, 2023 05:29
@navinkarkera
Copy link
Contributor Author

This is ready to be merged now.

@robrap robrap merged commit 37a84a7 into openedx:main Jun 26, 2023
@openedx-webhooks
Copy link

@navinkarkera 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@navinkarkera navinkarkera deleted the navin/configurable-handler-adr branch June 26, 2023 14:20
@navinkarkera navinkarkera mentioned this pull request Jul 19, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ian2012 Ian2012 Ian2012 left review comments

@robrap robrap robrap approved these changes

@mariajgrimaldi mariajgrimaldi mariajgrimaldi approved these changes

@timmc-edx timmc-edx timmc-edx approved these changes

@tecoholic tecoholic tecoholic approved these changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@navinkarkera @openedx-webhooks @mphilbrick211 @sameenfatima78 @robrap @tecoholic @Ian2012 @timmc-edx @mariajgrimaldi